Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

リリースノート修正 #104

Merged
merged 5 commits into from
Jul 27, 2024
Merged

リリースノート修正 #104

merged 5 commits into from
Jul 27, 2024

Conversation

ttizze
Copy link
Owner

@ttizze ttizze commented Jul 27, 2024

Closes #103

Summary by CodeRabbit

### リリースノート

#### Chore
- `.github/release-drafter.yml`の正規表現パターンとインデントを修正し、シングルクォートをダブルクォートに変更しました。
- `.github/workflows/link-pr-to-issue.yml`でGitHub Actionsワークフローの入力定義、チェックアウトステップ、PR番号取得方法、権限設定、コメントおよびラベル付け順序を改善しました。
- `.github/workflows/ai-review.yaml`にインデントの問題を無視しない指示を追加しました。
- `.github/workflows/biome.yaml`のシングルクォートをダブルクォートに変更し、ファイル末尾に改行を追加しました。

Copy link

github-actions bot commented Jul 27, 2024

Image description CodeRabbit

### ウォークスルー

この変更では、GitHub Actionsのワークフローと設定ファイルに対する一連の修正が行われました。主な変更点は、インデントやクォートスタイルの統一、ブランチ名パターンの簡略化、PRとIssueのリンク処理の改善です。

### 変更点

| ファイル | 要約 |
| --- | --- |
| .github/release-drafter.yml | 正規表現のパターンから先頭の `^` を削除し、いくつかのラベルに対応するブランチ名のパターンを簡略化しました。シングルクォートからダブルクォートへの変更を行い、インデントの修正を含んでいます。 |
| .github/workflows/link-pr-to-issue.yml | `workflow_dispatch`イベントの入力定義の修正、リポジトリのチェックアウトステップの追加、PR番号の取得方法の修正、`permissions`セクションの追加、コメントおよびラベル付けの順序の変更、PRとIssueのリンク処理の改善。 |
| .github/workflows/ai-review.yaml, .github/workflows/biome.yaml | インデントの問題を無視しないようにするための指示が追加され、シングルクォートをダブルクォートに変更し、ファイルの末尾に改行を追加しています。 |

Uplevel your code reviews with CodeRabbit Pro

CodeRabbit Pro

If you like this project, please support us by purchasing the Pro version. The Pro version has advanced context, superior noise reduction and several proprietary improvements compared to the open source version. Moreover, CodeRabbit Pro is free for open source projects.

Copy link

@github-actions github-actions bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Image description CodeRabbit

Commits Files that changed from the base of the PR and between 4e57b57 and ff61772 commits.
Files selected (1)
  • .github/release-drafter.yml (1)
Review comments generated (2)
  • Review: 1
  • LGTM: 1

Tips

Chat with Image description CodeRabbit Bot (@coderabbitai)

  • Reply on review comments left by this bot to ask follow-up questions. A review comment is a comment on a diff or a file.
  • Invite the bot into a review comment chain by tagging @coderabbitai in a reply.

Code suggestions

  • The bot may make code suggestions, but please review them carefully before committing since the line number ranges may be misaligned.
  • You can edit the comment made by the bot and manually tweak the suggestion if it is slightly off.

Pausing incremental reviews

  • Add @coderabbitai: ignore anywhere in the PR description to pause further reviews from the bot.

.github/release-drafter.yml Outdated Show resolved Hide resolved
Copy link

@github-actions github-actions bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Image description CodeRabbit

Commits Files that changed from the base of the PR and between ff61772 and fc122ec commits.
Files selected (1)
  • .github/workflows/link-pr-to-issue.yml (3)
Review comments generated (4)
  • Review: 2
  • LGTM: 2

Tips

Chat with Image description CodeRabbit Bot (@coderabbitai)

  • Reply on review comments left by this bot to ask follow-up questions. A review comment is a comment on a diff or a file.
  • Invite the bot into a review comment chain by tagging @coderabbitai in a reply.

Code suggestions

  • The bot may make code suggestions, but please review them carefully before committing since the line number ranges may be misaligned.
  • You can edit the comment made by the bot and manually tweak the suggestion if it is slightly off.

Pausing incremental reviews

  • Add @coderabbitai: ignore anywhere in the PR description to pause further reviews from the bot.

Comment on lines +31 to 33
PR_NUMBER="${{ github.event.pull_request.number }}"
BRANCH_NAME="${{ github.head_ref }}"
fi

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Image description CodeRabbit

The indentation of the PR_NUMBER and BRANCH_NAME assignments is inconsistent. It should be aligned with the surrounding code.

-             PR_NUMBER="${{ github.event.pull_request.number }}"
-              BRANCH_NAME="${{ github.head_ref }}"
+            PR_NUMBER="${{ github.event.pull_request.number }}"
+            BRANCH_NAME="${{ github.head_ref }}"

.github/workflows/link-pr-to-issue.yml Outdated Show resolved Hide resolved
Copy link

This PR is linked to issue #103

Copy link

@github-actions github-actions bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Image description CodeRabbit

Commits Files that changed from the base of the PR and between fc122ec and 7e31041 commits.
Files selected (1)
  • .github/workflows/link-pr-to-issue.yml (3)
Review comments generated (5)
  • Review: 2
  • LGTM: 3

Tips

Chat with Image description CodeRabbit Bot (@coderabbitai)

  • Reply on review comments left by this bot to ask follow-up questions. A review comment is a comment on a diff or a file.
  • Invite the bot into a review comment chain by tagging @coderabbitai in a reply.

Code suggestions

  • The bot may make code suggestions, but please review them carefully before committing since the line number ranges may be misaligned.
  • You can edit the comment made by the bot and manually tweak the suggestion if it is slightly off.

Pausing incremental reviews

  • Add @coderabbitai: ignore anywhere in the PR description to pause further reviews from the bot.

.github/workflows/link-pr-to-issue.yml Outdated Show resolved Hide resolved
Copy link

@github-actions github-actions bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Image description CodeRabbit

Commits Files that changed from the base of the PR and between 7e31041 and 89585c2 commits.
Files selected (4)
  • .github/release-drafter.yml (2)
  • .github/workflows/ai-review.yaml (1)
  • .github/workflows/biome.yaml (2)
  • .github/workflows/link-pr-to-issue.yml (3)
Files skipped from review due to trivial changes (3)
  • .github/release-drafter.yml
  • .github/workflows/ai-review.yaml
  • .github/workflows/biome.yaml
Review comments generated (6)
  • Review: 2
  • LGTM: 4

Tips

Chat with Image description CodeRabbit Bot (@coderabbitai)

  • Reply on review comments left by this bot to ask follow-up questions. A review comment is a comment on a diff or a file.
  • Invite the bot into a review comment chain by tagging @coderabbitai in a reply.

Code suggestions

  • The bot may make code suggestions, but please review them carefully before committing since the line number ranges may be misaligned.
  • You can edit the comment made by the bot and manually tweak the suggestion if it is slightly off.

Pausing incremental reviews

  • Add @coderabbitai: ignore anywhere in the PR description to pause further reviews from the bot.

.github/workflows/link-pr-to-issue.yml Show resolved Hide resolved
.github/workflows/link-pr-to-issue.yml Show resolved Hide resolved
@ttizze ttizze merged commit d5cc2b5 into main Jul 27, 2024
4 checks passed
@ttizze ttizze deleted the ttizze/bug-issue-103 branch July 27, 2024 08:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

リリースノート修正
1 participant